Merged
Conversation
added 10 commits
June 10, 2021 14:24
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 79.34% 80.91% +1.57%
==========================================
Files 150 206 +56
Lines 9736 14237 +4501
==========================================
+ Hits 7725 11520 +3795
- Misses 2011 2717 +706
Continue to review full report at Codecov.
|
Member
hunterhector
left a comment
There was a problem hiding this comment.
Looks good, not many comments. Probably we can move the __dict__ operation inside DataPack now, but still, keep the current implementation. We can open another PR to implement the update interface carefully with test cases.
hunterhector
approved these changes
Jun 14, 2021
This was referenced Jun 16, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #475.
Description of changes
pipeline.py:Pipeline().save().Pipeline().serve().forte.serve().RemoteProcessor:DataPackto a POST request and update the input according to the response from service.RawDataDeserializeReader.Possible influences of this PR.
For
pylintchecking,Pipelineclass has reached the maximum number of public methods (20/20)Test Conducted
A unit test
remote_processor_test.pyis provided to verify the intermediate representation and RemoteProcessor.