Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implementing Character Flipping Data Augmentation#536

Merged
hunterhector merged 9 commits intoasyml:masterfrom
ArnavParekhji:master
Oct 20, 2021
Merged

Implementing Character Flipping Data Augmentation#536
hunterhector merged 9 commits intoasyml:masterfrom
ArnavParekhji:master

Conversation

@ArnavParekhji
Copy link
Contributor

Description of changes

Added Character Flipping Data Augmentation to randomly flip certain characters in the text to other similar-looking characters.

Possible influences of this PR.

Additional Data Augmentation Task is added to Forte by this PR

Test Conducted

Asserts if the generated and expected texts are equal.

Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems good. Probably try to improve the documentation, make it easy for users to understand the op easily.

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #536 (243e51b) into master (ff8c61f) will increase coverage by 0.03%.
The diff coverage is 90.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   79.58%   79.62%   +0.03%     
==========================================
  Files         222      224       +2     
  Lines       15917    15968      +51     
==========================================
+ Hits        12668    12714      +46     
- Misses       3249     3254       +5     
Impacted Files Coverage Δ
...ssors/data_augment/algorithms/character_flip_op.py 87.09% <87.09%> (ø)
.../data_augment/algorithms/character_flip_op_test.py 95.00% <95.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8c61f...243e51b. Read the comment docs.

Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hunterhector
hunterhector previously approved these changes Oct 18, 2021
Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good if all tests pass

@hunterhector hunterhector merged commit 9246e38 into asyml:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants