Add metric ontology#568
Merged
hunterhector merged 24 commits intoasyml:masterfrom Jan 19, 2022
zhanyuanucb:issue#556
Merged
Conversation
Member
|
Could you do the following to make sure the PR is up to standard?
|
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
=======================================
Coverage 80.07% 80.07%
=======================================
Files 234 234
Lines 16538 16538
=======================================
Hits 13243 13243
Misses 3295 3295
Continue to review full report at Codecov.
|
Member
hunterhector
left a comment
There was a problem hiding this comment.
We normally also add the generated class to Forte repo so users don't have to re-generate these.
hunterhector
approved these changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #566
Description of changes
Added
forte/ontology_specs/metric.jsonPossible influences of this PR.
Due to the
ndarrayattribute inNdMetric, the metric ontology spec isn't ready to be auto-generated by the current ontology generator yet.Test Conducted
Unit tests are to be added