Datastore Generics & AudioAnnotation#800
Datastore Generics & AudioAnnotation#800mylibrar merged 26 commits intoasyml:masterfrom hepengfe:datastore_generics
Conversation
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
==========================================
+ Coverage 81.17% 81.20% +0.02%
==========================================
Files 249 249
Lines 18868 18914 +46
==========================================
+ Hits 15316 15359 +43
- Misses 3552 3555 +3
Continue to review full report at Codecov.
|
hunterhector
left a comment
There was a problem hiding this comment.
Mainly documentation issues, but Query from the top.py is not supported in the add section
forte/data/data_store.py
Outdated
|
|
||
| def _get_existing_entry_tid(self, entry: List[Any]): | ||
| r""" | ||
| This function searches for tid for existing entry tid. It return tid |
There was a problem hiding this comment.
Should document that we search for Annotation-like data, and provide that which types can be searched here (and based on what to search)
There was a problem hiding this comment.
I think we might need to support non-Annotation like data in the future. So I am raising errors with messages to inform users when the non-supported data entry is provided.
There was a problem hiding this comment.
actually, we probably won't do that, the purpose of this function is only searching duplicate in position (e.g begin and end). but this is not quite important
|
Let's just pass the CI and merge this. |
This PR fixes #773 and #772
Description of changes
Possible influences of this PR.
Describe what are the possible side-effects of the code change.
Test Conducted
Describe what test cases are included for the PR.