Check duplicates when adding new annotation to DataStore#801
Merged
mylibrar merged 4 commits intoasyml:masterfrom May 24, 2022
Merged
Check duplicates when adding new annotation to DataStore#801mylibrar merged 4 commits intoasyml:masterfrom
mylibrar merged 4 commits intoasyml:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
==========================================
- Coverage 81.09% 81.08% -0.01%
==========================================
Files 249 249
Lines 18748 18765 +17
==========================================
+ Hits 15203 15216 +13
- Misses 3545 3549 +4
Continue to review full report at Codecov.
|
added 2 commits
May 24, 2022 14:08
hunterhector
previously approved these changes
May 24, 2022
hunterhector
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #774.
Description of changes
allow_duplicateto specify whether to add identical entries into DataPack. If it's set toFalse, thenadd_annnotation_rawshould just return the existing entry if a duplicate is found.Test Conducted
test_add_annotation_rawis updated to test duplicate checking