Data adder for data pack#896
Merged
hepengfe merged 22 commits intoasyml:masterfrom Aug 26, 2022
hepengfe:data_adder
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 80.88% 80.85% -0.03%
==========================================
Files 254 254
Lines 19599 19607 +8
==========================================
+ Hits 15852 15854 +2
- Misses 3747 3753 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mylibrar
reviewed
Aug 22, 2022
Collaborator
mylibrar
left a comment
There was a problem hiding this comment.
So where are the add_audio and add_text functions?
Collaborator
Author
I deleted in one commit accidentally. I have added it back. |
mylibrar
reviewed
Aug 22, 2022
mylibrar
reviewed
Aug 26, 2022
mylibrar
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #895
Description of changes
add_textto add text into DataPackadd_audioto add audio into DataPackPossible influences of this PR.
Describe what are the possible side-effects of the code change.
Test Conducted
Describe what test cases are included for the PR.