perf(types): reduce type instantiations for Promise<void> middleware #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR optimizes TypeScript type instantiations for middleware that returns Promise<void> by refactoring several key utility types to reduce computational overhead during type checking.
Key Changes:
- Refactored
Promise<void>handling to returnneverinMergeTypedResponse, eliminating redundant conditional checks in downstream types - Unrolled
IntersectNonAnyTypestype with explicit cases for arrays up to 10 elements to reduce recursive type instantiations - Restructured
ToSchemato handlenevercase early and movedIsAnycheck into the conditional branch
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Comment on lines
+2387
to
2411
| export type IntersectNonAnyTypes<T extends any[]> = T extends [] | ||
| ? {} | ||
| : T extends [infer H1] | ||
| ? ProcessHead<H1> | ||
| : T extends [infer H1, infer H2] | ||
| ? ProcessHead<H1> & ProcessHead<H2> | ||
| : T extends [infer H1, infer H2, infer H3] | ||
| ? ProcessHead<H1> & ProcessHead<H2> & ProcessHead<H3> | ||
| : T extends [infer H1, infer H2, infer H3, infer H4] | ||
| ? ProcessHead<H1> & ProcessHead<H2> & ProcessHead<H3> & ProcessHead<H4> | ||
| : T extends [infer H1, infer H2, infer H3, infer H4, infer H5] | ||
| ? ProcessHead<H1> & ProcessHead<H2> & ProcessHead<H3> & ProcessHead<H4> & ProcessHead<H5> | ||
| : T extends [infer H1, infer H2, infer H3, infer H4, infer H5, infer H6] | ||
| ? ProcessHead<H1> & ProcessHead<H2> & ProcessHead<H3> & ProcessHead<H4> & ProcessHead<H5> & ProcessHead<H6> | ||
| : T extends [infer H1, infer H2, infer H3, infer H4, infer H5, infer H6, infer H7] | ||
| ? ProcessHead<H1> & ProcessHead<H2> & ProcessHead<H3> & ProcessHead<H4> & ProcessHead<H5> & ProcessHead<H6> & ProcessHead<H7> | ||
| : T extends [infer H1, infer H2, infer H3, infer H4, infer H5, infer H6, infer H7, infer H8] | ||
| ? ProcessHead<H1> & ProcessHead<H2> & ProcessHead<H3> & ProcessHead<H4> & ProcessHead<H5> & ProcessHead<H6> & ProcessHead<H7> & ProcessHead<H8> | ||
| : T extends [infer H1, infer H2, infer H3, infer H4, infer H5, infer H6, infer H7, infer H8, infer H9] | ||
| ? ProcessHead<H1> & ProcessHead<H2> & ProcessHead<H3> & ProcessHead<H4> & ProcessHead<H5> & ProcessHead<H6> & ProcessHead<H7> & ProcessHead<H8> & ProcessHead<H9> | ||
| : T extends [infer H1, infer H2, infer H3, infer H4, infer H5, infer H6, infer H7, infer H8, infer H9, infer H10] | ||
| ? ProcessHead<H1> & ProcessHead<H2> & ProcessHead<H3> & ProcessHead<H4> & ProcessHead<H5> & ProcessHead<H6> & ProcessHead<H7> & ProcessHead<H8> & ProcessHead<H9> & ProcessHead<H10> | ||
| : T extends [infer Head, ...infer Rest] | ||
| ? ProcessHead<Head> & IntersectNonAnyTypes<Rest> | ||
| : {} |
There was a problem hiding this comment.
[nitpick] The IntersectNonAnyTypes type has been unrolled for performance optimization with hardcoded cases up to 10 elements. However, this approach sacrifices maintainability for performance gains. Consider adding a comment explaining:
- Why the unrolling stops at 10 elements
- The performance tradeoff being made
- What happens with arrays longer than 10 elements (falls back to recursive case)
This will help future maintainers understand the design decision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.