Add -p shorthand to bk build view for pipeline flag #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support -p as shorthand for --pipeline in build view Aligns with other build subcommands (new, list, watch, rebuild, cancel)
mcncl
requested changes
Sep 8, 2025
Contributor
There was a problem hiding this comment.
We could actually use persistentFlags on the base build.go
cmd.PersistentFlags().StringP("pipeline", "p", "", "The pipeline to use. This can be a {pipeline slug} or in the format {org slug}/{pipeline slug}.")And where we want to get the flag, such as in view.go file we could use the following before we use the resolvers (line 59)
opts.Pipeline, _ = cmd.Flags().GetString("pipeline")Then each setting of -p or --pipeline in view.go, list.go etc can be deleted
2. All subcommands use cmd.Flags().GetString(pipeline) 3. All duplicate flags removed from individual commands 4. Tested
mcncl
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build view
Previously we had an error:
bk build view -p --branch 'main'| cat
Error: unknown shorthand flag: 'p' in -p