Improve @babel/core typings #17471
Merged
Improve @babel/core typings #17471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
commented
Aug 7, 2025
| sourceMaps, | ||
|
|
||
| // babel-generator does not differentiate between `true`, `"inline"` or `"both"` | ||
| sourceMaps: !!sourceMaps, |
Contributor
Author
There was a problem hiding this comment.
Here we cast generatorOpts.sourceMaps to boolean as required by the @babel/generator.
383d697 to
50a8795
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59842 |
JLHwung
commented
Aug 7, 2025
| "private": true, | ||
| "type": "module", | ||
| "devDependencies": { | ||
| "$repo-utils": "link:../scripts/repo-utils", |
Contributor
Author
There was a problem hiding this comment.
This is a private package and will probably never be published, so we simply add $repo-utils here.
JLHwung
commented
Aug 7, 2025
| parserOpts?: ParserOptions; | ||
| // Deprecate top level generatorOpts | ||
| // Todo(Babel 9): Deprecate top level generatorOpts | ||
| generatorOpts?: GeneratorOptions; |
Contributor
Author
There was a problem hiding this comment.
The todo items have been here since 8 years ago, but I am not sure if we want to do it in Babel 8.
|
commit: |
6d4abc9 to
4b8fe00
Compare
The error will not be printed if failed fast
The size reduction comes from terser upgrade in the previous commit
4b8fe00 to
a80e2d8
Compare
liuxingbaoyu
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we improved the typings of
@babel/core: For every functional properties inInputOptionsandPluginObject, it is now annotated with specific signatures. We also fixed incorrect typings in theloadOptionsAPI.We also added a new typing export for
@babel/traverse:VisitWrapper, used by theInputOptions#wrapPluginVisitorMethod. There is no new typing export from@babel/corethough.Also specified
terseras devDependency since it is required by the@babel/helpersbuild scripts.