-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix traverse NodePath caching #17568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix traverse NodePath caching #17568
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60125 |
|
commit: |
|
Thanks!
|
be8e6b8 to
9d9779b
Compare
|
We can just revert the change in
|
|
@liuxingbaoyu should I just remove this line instead of checking |
|
Removing the |
|
@liuxingbaoyu as I see only removing check for make build && BABEL_8_BREAKING=true yarn jest babel-traverseSo with this line or without, additional check for |
|
Pending @liuxingbaoyu's investigation result. |
|
Well, I added The fix we made in this PR conflicts with #17565, preventing it from fixing #17563. |
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:/
Uh oh!
There was an error while loading. Please reload this page.