[Babel 8] fix: Improve traverse types
#17574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
path.is*traverse types
liuxingbaoyu
commented
Oct 27, 2025
| import { scope as scopeCache } from "../cache.ts"; | ||
| import type { ExplodedVisitor, Visitor } from "../types.ts"; | ||
|
|
||
| export type { BindingKind }; |
Member
Author
There was a problem hiding this comment.
Export this type because DefinitelyTyped exports it and it is used by users.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60233 |
liuxingbaoyu
commented
Oct 27, 2025
Comment on lines
17
to
25
| it("assert", () => { | ||
| traverse({} as any, { | ||
| Expression(path: NodePath<t.Expression>) { | ||
| // @ts-expect-error Assertions require every name in the call target to be declared with an explicit type annotation. | ||
| path.assertIdentifier(); | ||
| expect(path).type.toBe<NodePath<t.Identifier>>(); | ||
| }, | ||
| }); | ||
| }); |
Member
Author
There was a problem hiding this comment.
I don't know how to fix this, DefinitelyTyped doesn't use the asserts keyword, it just returns void.
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
I suggest checking for open issues first, I'm worried that it's "by design".
57d3038 to
ba68a2c
Compare
|
commit: |
1b042b0 to
97b289e
Compare
JLHwung
approved these changes
Nov 25, 2025
nicolo-ribaudo
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2These are issues I encountered when upgrading
babel-plugin-react-compiler.