Make "object without properties" helpers ES6-compatible#17086
Make "object without properties" helpers ES6-compatible#17086nicolo-ribaudo merged 3 commits intobabel:mainfrom tquetano-netflix:object-without-properties-use-indexof
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58632 |
|
Could you run |
|
Rather make ES6-compatible since in this branch present |
|
@zloirock based on the feedback in the original issue, as well as the fact the ESLint rule to prefer I realize that seems like a niche scenario, but considering the cost of closing that gap definitively is basically zero, not sure what benefit there is with that coupling. |
|
@tquetano-netflix I didn't say it's wron way. It's just a question of the title -) |
|
@zloirock Ah! My apologies for the misread, it's late for me. 😅 Feel free to make the title whatever makes the most sense, @nicolo-ribaudo has already updated it once. |
Changes since last version: babel/babel#17173 babel/babel#17086 babel/babel#16794
Changes since last version: babel/babel#17173 babel/babel#17086 babel/babel#16794
Updating the
objectWithoutProperties/objectWithoutPropertiesLoosehelpers to use.indexOf()checks instead of.includes(), and disable the lint rule that was enforcing an auto-fix in those files.