Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Create single threaded Feature with scheduler #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 4, 2022
Merged

Create single threaded Feature with scheduler #158

merged 15 commits into from
Aug 4, 2022

Conversation

@LachlanMcKee
Copy link
Collaborator

@LachlanMcKee LachlanMcKee commented Jul 18, 2022 •
edited
Loading

This PR contains the following:

  • Reverted BaseFeature back to how it originally was.
  • Moved the AsyncFeature logic into BaseAsyncFeature
  • Added a single threaded scheduler to BaseFeature
    • This will allow the feature to smartly switch back to the feature thread without developer intervention
  • Created a factory to create these schedulers

Feedback greatly appreciated!

@LachlanMcKee
Copy link
Collaborator Author

@CherryPerry I don't suppose you would mind taking a look when you get a chance? :)

CherryPerry
CherryPerry reviewed Jul 22, 2022
View reviewed changes
@LachlanMcKee LachlanMcKee force-pushed the split-async-and-sync-base-feature branch 3 times, most recently from fea2ce7 to 041beb8 Compare July 22, 2022 21:16
@LachlanMcKee LachlanMcKee changed the title [Draft] Create single threaded Feature with scheduler Create single threaded Feature with scheduler Jul 22, 2022
@LachlanMcKee LachlanMcKee force-pushed the split-async-and-sync-base-feature branch from 041beb8 to 30f06d7 Compare July 22, 2022 21:35
@LachlanMcKee
Copy link
Collaborator Author

@CherryPerry I'm pretty happy with where the PR is now. I don't consider this a draft anymore

CherryPerry
CherryPerry requested changes Aug 3, 2022
View reviewed changes
@LachlanMcKee LachlanMcKee force-pushed the split-async-and-sync-base-feature branch 2 times, most recently from 374d15e to dfa6fb9 Compare August 3, 2022 14:42
CherryPerry
CherryPerry reviewed Aug 3, 2022
View reviewed changes
@LachlanMcKee LachlanMcKee force-pushed the split-async-and-sync-base-feature branch from dfa6fb9 to c91156c Compare August 3, 2022 14:48
LachlanMcKee and others added 14 commits August 3, 2022 18:02
@LachlanMcKee
Copied BaseFeature as BaseAsyncFeature
2d3f03a
@LachlanMcKee
Reverted BaseFeature behaviour and removed BaseAsync nullability
b8cbe79
@LachlanMcKee
Moved FeatureSchedulers into AsyncBaseFeature
0bc241b
@LachlanMcKee
Updated BaseFeature to automatically switch to provided feature sched…
8dbe512 
…uler
@LachlanMcKee
Created FeatureSchedulerFactory to allow creation of non-main thread …
88b4827 
…schedulers
@LachlanMcKee
Updated MVICore demo to use featureScheduler
8651cca
@LachlanMcKee
Improved feature scheduler switching logic
39baca8
@LachlanMcKee
Reintroduced disposables memory leak fix
cbdb442
@LachlanMcKee
Added test to ensure BaseFeature is unit testable
b6eed1d
@LachlanMcKee
Restructured FeatureSchedulers
b6817fa
@LachlanMcKee
Renamed ActorReducerFeatureTestSchedulerTest
a58c7b8
@LachlanMcKee
Removed unused mockito invocation
dcaef22
@LachlanMcKee
Minor codestyle improvements
1cbb803
@LachlanMcKee
Removed onNext behaviour from observeOnFeatureScheduler
53aa5f3
@LachlanMcKee LachlanMcKee force-pushed the split-async-and-sync-base-feature branch from c91156c to 53aa5f3 Compare August 3, 2022 17:03
@CherryPerry CherryPerry merged commit 5eb115f into badoo:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CherryPerry CherryPerry CherryPerry approved these changes

+1 more reviewer

@zsoltk zsoltk zsoltk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LachlanMcKee @zsoltk @CherryPerry