Add dialog support (WIP) #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShikaSD
reviewed
Mar 22, 2019
...-example/src/androidTest/java/com/badoo/ribs/example/rib/dialog_example/DialogExampleTest.kt
Show resolved
Hide resolved
android/app-example/src/main/java/com/badoo/ribs/example/rib/blocker/Blocker.kt
Outdated
Show resolved
Hide resolved
...id/app-example/src/androidTest/java/com/badoo/ribs/example/rib/lorem_ipsum/LoremIpsumTest.kt
Show resolved
Hide resolved
...xample/src/androidTest/java/com/badoo/ribs/example/rib/hello_world/HelloWorldTestDeferred.kt
Show resolved
Hide resolved
android/app-example/src/main/java/com/badoo/ribs/example/rib/blocker/builder/BlockerModule.kt
Show resolved
Hide resolved
| loremIpsumBuilder: LoremIpsumBuilder | ||
| ) : Dialog<Dialog.Event>({ | ||
| title = "A title if you wish" | ||
| ribFactory { |
Contributor
There was a problem hiding this comment.
Factory is not serializable, is it fine?
Contributor
Author
There was a problem hiding this comment.
I guess this is in reference to passing the dialog around in a Configuration data class. I guess if it's a RIB inside, it already has its whole infrastructure for dynamic updates (input deps or internal feature impl).
Contributor
There was a problem hiding this comment.
Will it handle this dialog correctly after restore though?
Contributor
Author
There was a problem hiding this comment.
Not this one, but that's the point - Dialogs that host RIBs do not even need to be serialised and passed inside the Configuration.
...d/app-example/src/main/java/com/badoo/ribs/example/rib/dialog_example/dialog/SimpleDialog.kt
Show resolved
Hide resolved
...oid/app-example/src/main/java/com/badoo/ribs/example/rib/hello_world/HelloWorldInteractor.kt
Outdated
Show resolved
Hide resolved
jeksor
suggested changes
Mar 22, 2019
...p-example/src/main/java/com/badoo/ribs/example/rib/dialog_example/DialogExampleInteractor.kt
Outdated
Show resolved
Hide resolved
...p-example/src/main/java/com/badoo/ribs/example/rib/dialog_example/DialogExampleInteractor.kt
Show resolved
Hide resolved
...p-example/src/main/java/com/badoo/ribs/example/rib/dialog_example/DialogExampleInteractor.kt
Show resolved
Hide resolved
...d/app-example/src/main/java/com/badoo/ribs/example/rib/dialog_example/DialogExampleRouter.kt
Outdated
Show resolved
Hide resolved
...d/app-example/src/main/java/com/badoo/ribs/example/rib/dialog_example/DialogExampleRouter.kt
Outdated
Show resolved
Hide resolved
...d/libraries/rib-base/src/main/java/com/badoo/ribs/core/routing/action/DialogRoutingAction.kt
Outdated
Show resolved
Hide resolved
android/libraries/rib-base/src/main/java/com/badoo/ribs/core/routing/action/RoutingAction.kt
Outdated
Show resolved
Hide resolved
...d/libraries/rib-base/src/main/java/com/badoo/ribs/core/routing/backstack/BackStackManager.kt
Outdated
Show resolved
Hide resolved
...p-example/src/main/java/com/badoo/ribs/example/rib/dialog_example/DialogExampleInteractor.kt
Show resolved
Hide resolved
android/app-example/src/main/java/com/badoo/ribs/example/rib/lorem_ipsum/LoremIpsum.kt
Show resolved
Hide resolved
lukaville
reviewed
Mar 22, 2019
...xample/src/main/java/com/badoo/ribs/example/rib/dialog_example/builder/DialogExampleScope.kt
Show resolved
Hide resolved
…ing previous step
ShikaSD
reviewed
Apr 1, 2019
...d/app-example/src/main/java/com/badoo/ribs/example/rib/dialog_example/DialogExampleRouter.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.