Updated to AGP 8.2.2 #397
Merged
Updated to AGP 8.2.2 #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed8645f to
9ff20b7
Compare
LachlanMcKee
commented
Sep 22, 2024
| # This option should only be used with decoupled projects. More details, visit | ||
| # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects | ||
| org.gradle.jvmargs=-Xmx4g -XX:MaxPermSize=512M | ||
| org.gradle.jvmargs=-Xmx2048m -Dfile.encoding=UTF-8 |
There was a problem hiding this comment.
Copied from Appyx after Github Actions decided it doesn't like MaxPermSize
70ce20b to
8eb3501
Compare
LachlanMcKee
commented
Sep 23, 2024
| matrix: | ||
| api-level: [22,25,29] | ||
| name: Instrumentation tests [API=${{ matrix.api-level }}] | ||
| name: Instrumentation tests |
There was a problem hiding this comment.
Copied from Appyx configuration as the previous RIBs setup was not working (and is very old)
8eb3501 to
83f3910
Compare
f7e65da to
0afb644
Compare
0afb644 to
98329e3
Compare
67bcdd2 to
9393b8c
Compare
c0ac147 to
0a9dedb
Compare
57b1fc6 to
afdc809
Compare
CherryPerry
approved these changes
Oct 1, 2024
.github/workflows/ci.yml
Outdated
| java-version: '17' | ||
| - name: Setup Gradle | ||
| uses: gradle/actions/setup-gradle@v3 | ||
| - uses: actions/cache@v4 |
There was a problem hiding this comment.
Remove cache step for Gradle, it is already set in gradle/actions/setup-gradle
There was a problem hiding this comment.
Good catch. will do!
.github/workflows/ci.yml
Outdated
| java-version: '17' | ||
| - name: Setup Gradle | ||
| uses: gradle/actions/setup-gradle@v3 | ||
| - uses: actions/cache@v4 |
gradle/gradle-mvn-push.gradle
Outdated
| developer { | ||
| id.set("badoo") | ||
| name.set("Badoo Trading Limited") | ||
| email.set("[email protected]") |
There was a problem hiding this comment.
Remove email? Looks like we did not have it before.
There was a problem hiding this comment.
weird. I swear I copied it from somewhere. will remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: