fix: 修复图标可能是组件的情况 #11280
Merged
fix: 修复图标可能是组件的情况 #11280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for this! Please review the labels and make any necessary changes. |
2betop
approved these changes
Nov 28, 2024
allenve
approved these changes
Nov 28, 2024
| const icon = filter(this.props.icon, data); | ||
| const rightIcon = filter(this.props.rightIcon, data); | ||
| let icon = this.props.icon; | ||
| let rightIcon = this.props.rightIcon; |
Contributor
There was a problem hiding this comment.
const icon = filter(this.props.icon, data) || this.props.icon
allenve
pushed a commit
to allenve/amis
that referenced
this pull request
Dec 13, 2024
2betop
pushed a commit
to kangzhanlei/amis
that referenced
this pull request
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How