don't try to install a 'tests' package at top level #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello Bas, first, I hope you don't mind I included your component for [Home Assistant Gentoo Overlay](https://github.com/onkelbeh/HomeAssistantRepository). I do not use this component myself. But, during compilation test, the installation test script threw an error, because `setup.py` tries to install a package called `tests` at top level. I currently patched this for now at my repo (https://github.com/onkelbeh/HomeAssistantRepository/blob/master/dev-python/aiokef/aiokef-0.2.16.ebuild). This change adds a generic exclusion to `find_packages()`. Thanks a lot. \B.
Contributor
Author
|
The failing build log: https://git.edevau.net/onkelbeh/HomeAssistantRepository/issues/186 |
basnijholt
reviewed
Oct 17, 2020
Owner
|
Thanks for this! 👍🙌🏼 |
Contributor
Author
|
Yeah black :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Bas,
first, I hope you don't mind I included your component for Home Assistant Gentoo Overlay. I do not use this component myself. But, during compilation test, the installation test script threw an error, because
setup.pytries to install a package calledtestsat top level.I currently patched this for now at my repo (https://github.com/onkelbeh/HomeAssistantRepository/blob/master/dev-python/aiokef/aiokef-0.2.16.ebuild).
This change adds a generic exclusion to
find_packages().Thanks a lot.
\B.