Refactor mcmc_update_z_position!!() #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a redundant call of `deepcopy()` which was bad for performance, and also cleans up the transformation of the samples by calling the BAT function `transform_samples()`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
==========================================
- Coverage 62.41% 62.35% -0.07%
==========================================
Files 110 110
Lines 4976 4967 -9
==========================================
- Hits 3106 3097 -9
Misses 1870 1870 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oschulz
requested changes
Sep 24, 2025
Collaborator
Author
|
I added the requested changes in one commit |
oschulz
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a redundant call of
deepcopy()which was bad for performance, and also cleans up the transformation of the samples by calling the BAT functiontransform_samples()