Thanks to visit codestin.com
Credit goes to github.com

Skip to content

install.sh: consider multilib #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2021
Merged

install.sh: consider multilib #452

merged 3 commits into from
Aug 7, 2021

Conversation

@kkang-wr
Copy link
Contributor

@kkang-wr kkang-wr commented Jun 10, 2021 •
edited
Loading

It may install files to /usr/lib64 when multilib is enabled. Add an
optional parameter for install.sh to support it.

Signed-off-by: Kai Kang [email protected]

@kkang-wr kkang-wr requested a review from a team as a code owner June 10, 2021 03:43
@martin-schulze-vireso
Copy link
Member

Please add a test for this feature.

martin-schulze-vireso
martin-schulze-vireso requested changes Jun 12, 2021
View reviewed changes
Copy link
Member

@martin-schulze-vireso martin-schulze-vireso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for this feature and document its usage on line 11-12

@martin-schulze-vireso martin-schulze-vireso added Waiting for Contributor Feedback The original contributor did not yet respond to the latest request Component: Packaging Regarding packaging for NPM, RPM, etc. Type: Enhancement and removed Waiting for Contributor Feedback The original contributor did not yet respond to the latest request labels Jul 19, 2021
@kkang-wr kkang-wr force-pushed the master branch 2 times, most recently from 4454b46 to a007515 Compare August 2, 2021 14:25
martin-schulze-vireso
martin-schulze-vireso requested changes Aug 2, 2021
View reviewed changes
Copy link
Member

@martin-schulze-vireso martin-schulze-vireso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual lib folder is not checked. This is already a shortcoming of the test you used as a source for copying. Could you fix both please?

@kkang-wr
Copy link
Contributor Author

kkang-wr commented Aug 5, 2021

The actual lib folder is not checked. This is already a shortcoming of the test you used as a source for copying. Could you fix both please?

Done.

kkang-wr and others added 3 commits August 7, 2021 13:32
@kkang-wr @martin-schulze-vireso
install.sh: consider multilib
e986339 
It may install files to /usr/lib64 when multilib is enabled. Add an
optional parameter for install.sh to support it.

And add test case for it. It just copied the first test case in
install.bats and pass the second parameter to script install.sh. Then
check files under libdir for both test cases. Add function teardown() in
install.bats as well.

Signed-off-by: Kai Kang <[email protected]>
@martin-schulze-vireso
Also do multilib uninstall
456d64b
@martin-schulze-vireso
Fix shellcheck issues
74a4bee
martin-schulze-vireso
martin-schulze-vireso approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@martin-schulze-vireso martin-schulze-vireso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the missing tests for successful removal of the lib folder which uncovered that uninstall.sh did not allow for configuring the lib folder. Fixed that too.

@martin-schulze-vireso martin-schulze-vireso merged commit 7ff2f3e into bats-core:master Aug 7, 2021
@kkang-wr
Copy link
Contributor Author

kkang-wr commented Aug 9, 2021

I added the missing tests for successful removal of the lib folder which uncovered that uninstall.sh did not allow for configuring the lib folder. Fixed that too.

Thanks.

@martin-schulze-vireso
Copy link
Member

Did you actually try to use this on an existing system @kkang-wr ? The internal code relies on a hardcoded path from libexec/bats-core/bin to lib/bats-core/*, so this failed for me in a bash docker container:

bash-4.4# ./install.sh /usr lib64
Installed Bats to /usr/bin/bats
bash-4.4# bats /bats-core/test
/usr/libexec/bats-core/bats: line 300: /usr/lib/bats-core/validator.bash: No such file or directory

The install script would actually have tell the bats binary about the changed lib path for this to work. This is basically the same issue as with uninstall.sh not knowing about the correct lib folder.

@kkang-wr
Copy link
Contributor Author

It is my fault. I'll fix it ASAP.

@kkang-wr
Copy link
Contributor Author

@martin-schulze-vireso I submiited a pr #487 to fix the issue. Would you like to review it, pleas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-schulze-vireso martin-schulze-vireso martin-schulze-vireso approved these changes

Assignees

No one assigned

Labels

Component: Packaging Regarding packaging for NPM, RPM, etc. Type: Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kkang-wr @martin-schulze-vireso