Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rrjjvv
Copy link

@rrjjvv rrjjvv commented Jun 2, 2022

I noticed these while reviewing the docs in preparation for my previous (and first) PR.

@rrjjvv rrjjvv requested a review from a team as a code owner June 2, 2022 09:11
Copy link
Member

@martin-schulze-vireso martin-schulze-vireso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleased add a changelog entry. There should already be a bullet for minor fixes in documentetion, so you can just add the issue number.

@martin-schulze-vireso martin-schulze-vireso merged commit c7825aa into bats-core:master Jun 2, 2022
@martin-schulze-vireso
Copy link
Member

Thanks for your contribution.

martin-schulze-vireso added a commit to rrjjvv/bats-core that referenced this pull request Jun 2, 2022
@rrjjvv
Copy link
Author

rrjjvv commented Jun 3, 2022

I fully intended to revert that link (though I see you re-did it to make it work beyond github itself) and add that entry. Hopefully you pushed it through with those changes because they were trivial and not because you thought I was abandoning it (just a tad busy these days)!

@rrjjvv rrjjvv deleted the doc-fixes branch June 3, 2022 01:58
@martin-schulze-vireso
Copy link
Member

Don't sorry, I was just passing by and could not resist.

martin-schulze-vireso added a commit to rrjjvv/bats-core that referenced this pull request Jun 5, 2022
martin-schulze-vireso added a commit to rrjjvv/bats-core that referenced this pull request Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants