Minor fix in Tutorial documentation #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-schulze-vireso
approved these changes
Jul 8, 2022
|
Thanks for your contribution. Strangely enough it is written correctly in the accompanying project: martin-schulze-vireso/bats-tutorial@ef115a1 I think we need a more automated way to transfer the code from the (tested) project to the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the issue mentioned in #562,
the example needs the following correction for a successful test.
The order of redirection is essential here.
As project.sh redirects $PORT on STDERR.
Just a request to the maintainers.
If the maintainers are thinking of rewriting the whole example,
I would request them to accept this PR and then work on it.
This will help me in having my first PR in bats-core.
Closed PRs don't look well on the GitHub profile.