Fix indentation #651
Merged
Fix indentation #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will have to wait for the next release. Maybe we can even get everything under shfmt and instate a test that ensures no deviation. |
|
OK, thank you! |
|
is |
|
I thought #651 (comment) is saying |
|
You are correct. Sorry about this. |
|
No problem! |
martin-schulze-vireso
added a commit
to akinomyoga/bats-core
that referenced
this pull request
Sep 18, 2022
6bc25f7 to
def9ee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed inconsistent indentations in editing the files for #650. Some part of the files uses 4 spaces while double spaces are used in the other part of the same files.
I also noticed that some files (
lib/bats-core/formatter.bash,lib/bats-core/semaphore.bash) are entirely indented by 4 spaces, but I have kept these files untouched though I notice that such files conflict with Contributor Guidelines.