Stricter parallel Exists Check
#691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 2 common implementations of `parallel`: GNU parallel (https://www.gnu.org/software/parallel/) and moreutils' parallel (https://manpages.debian.org/testing/moreutils/parallel.1.en.html, https://linux.die.net/man/1/parallel). The former is much more feature rich and is the actual intended dependency of parallel tests in bats. The latter is far more common on many operating systems (including Ubuntu). Currently, when the `parallel.bats` file runs, it checks to see if `parallel` is available and will skip the test if not. Unfortunately, this only checks that there is _a_ `parallel` command available -- not necessarily the correct one. If moreutils parallel is installed, the skip will not occur and the test will later fail in "libexec/bats-core/bats-exec-suite", when trying to run `parallel --keep-order --jobs ...` -- these CLI args are unknown to moreutils `parallel`. This PR improves the check such that not _any_ `parallel` command will work. This check is extended by checking that the `parallel` command supports `--version`, which distinguishes between GNU parallel (supported) and moreutils parallel (unsupported).
This was referenced Jan 10, 2023
|
This check should also be updated in libexec/bats. And we should make a test for that. |
|
Added to description that this fixes #672. |
martin-schulze-vireso
approved these changes
Jan 13, 2023
martin-schulze-vireso
added a commit
to qec-pconner/bats-core
that referenced
this pull request
Jan 14, 2023
1043399 to
9a3b136
Compare
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 common implementations of
parallel: GNU parallel (https://www.gnu.org/software/parallel/) and moreutils' parallel (https://manpages.debian.org/testing/moreutils/parallel.1.en.html, https://linux.die.net/man/1/parallel).The former is much more feature rich and is the actual intended dependency of parallel tests in bats.
The latter is far more common on many operating systems (including Ubuntu).
Currently, when the
parallel.batsfile runs, it checks to see ifparallelis available and will skip the test if not. Unfortunately, this only checks that there is aparallelcommand available -- not necessarily the correct one. If moreutils parallel is installed, the skip will not occur and the test will later fail in "libexec/bats-core/bats-exec-suite", when trying to runparallel --keep-order --jobs ...-- these CLI args are unknown to moreutilsparallel.This PR improves the check such that not any
parallelcommand will work. This check is extended by checking that theparallelcommand supports--version, which distinguishes between GNU parallel (supported) and moreutils parallel (unsupported).Fixes #672.