Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix --gather-test-output-in fails on multiple / in test name #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2024
Merged

Fix --gather-test-output-in fails on multiple / in test name #789

merged 1 commit into from
Jan 27, 2024

Conversation

@jandubois
Copy link
Contributor

Expands on #735 which only fixed #688 for tests with a single slash

@jandubois jandubois requested a review from a team as a code owner September 14, 2023 06:37
@martin-schulze-vireso
Copy link
Member

martin-schulze-vireso commented Dec 18, 2023 •
edited
Loading

Thanks for your contribution. Can you also write a changelog entry please?

@jandubois
Copy link
Contributor Author

Thanks for your contribution. Can you also write a changelog entry please?

Sorry, this somehow slipped under my radar. I've rebased the PR on latest master and added the changelog entry.

@jandubois
Copy link
Contributor Author

I see the test failures, but I don't see how they would be related to the changes in my PR.

Is there anything I need to do? Or are these flaky tests that you'll just re-run until they pass?

@brokenpip3
Copy link
Contributor

I see the test failures, but I don't see how they would be related to the changes in my PR.

Is there anything I need to do? Or are these flaky tests that you'll just re-run until they pass?

yeah the freebsd one can fail or killed due to timeout, I ran the tests again but since Martin merged some other PRs you may need to rebase your branch and fix the conflicts

@jandubois
Fix --gather-test-output-in fails on multiple / in test name
e6981bf 
Expands on bats-core#735 which only fixed bats-core#688 for tests with a single slash

Signed-off-by: Jan Dubois <[email protected]>
@martin-schulze-vireso martin-schulze-vireso merged commit 990d8e2 into bats-core:master Jan 27, 2024
@jandubois jandubois deleted the multiple-slashes branch January 28, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-schulze-vireso martin-schulze-vireso martin-schulze-vireso approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test names containing "/" break --gether-test-outputs-in

3 participants

@jandubois @martin-schulze-vireso @brokenpip3