Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jasonkarns
Copy link
Member

@jasonkarns jasonkarns commented Jun 12, 2018

@jasonkarns jasonkarns requested a review from a team as a code owner June 12, 2018 03:04
@ghost ghost assigned jasonkarns Jun 12, 2018
@ghost ghost added the review label Jun 12, 2018
@jasonkarns
Copy link
Member Author

Would like to fix the license shield as well, but unsure how to tackle yet.

GitHub's parsed metadata reports unknown license: https://api.github.com/repos/bats-core/bats-core

Github is supposed to use licensee gem, which sorta identifies the right license:

$ licensee 
License:        NOASSERTION
Matched files:  LICENSE.md, package.json
LICENSE.md:
  Content hash:  b3c0fbcf548230f1eeeabfecbb199b06be37e1e0
  License:       NOASSERTION
  Closest licenses:
    MIT similarity:      87.08%
    BSL-1.0 similarity:  64.63%
    UPL-1.0 similarity:  61.89%
package.json:
  Confidence:  90.00%
  Matcher:     Licensee::Matchers::NpmBower
  License:     MIT

Did a little searching and apparently a lot of other repos have had the same issue (licenses no longer correctly being identified by github). So presumably the licensee gem report doesn't really matter.

Copy link
Contributor

@mbland mbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unless others have reservations, I say merge when ready.

@jasonkarns jasonkarns merged commit a4bccca into master Jun 12, 2018
@ghost ghost removed the review label Jun 12, 2018
@jasonkarns jasonkarns deleted the readme-badges branch June 12, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants