README: Update installation for macOS, npm #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tweaks the Gitter badge link (it was wreaking havoc on my Markdown syntax highligter in Vim) and one of the headline tags.
jasonkarns
reviewed
Jun 14, 2018
README.md
Outdated
|
|
||
| - [Installation](#installation) | ||
| - [Supported Bash versions](#supported-bash-versions) | ||
| - [macOS](#macos) |
There was a problem hiding this comment.
Mind titling this as brew or homebrew? The other installation methods are titled via the "how", not the host platform. (Seems weird that "macOS" and "npm" would be alternative installation methods since installing via npm is one possible installation method for macOS. As would be installing from source.)
There was a problem hiding this comment.
Good point; done. Will merge once the builds finish passing.
jasonkarns
approved these changes
Jun 14, 2018
Per @jasonkarns's comment in #104, it makes more sense to highlight Homebrew versus macOS, since Homebrew isn't the only method available on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tweaks the Gitter badge link (it was wreaking havoc on my Markdown syntax highlighter in Vim) and one of the headline tags.
cc: @kenden