Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add --errexit flag to enable errexit in run commands #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jandubois wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add --errexit flag to enable errexit in run commands #1118

jandubois wants to merge 2 commits into from

Conversation

@jandubois
Copy link
Contributor

@jandubois jandubois commented Jul 27, 2025

  • Set BATS_RUN_ERREXIT environment variable when flag is provided.
  • Write $? to a temp file when errexit is enabled.

I've tried for several hours, but have been unable to find a solution without using a temp file. I don't quite understand why, but I couldn't make it work.

Fixes #719
Fixes #748

@jandubois jandubois requested a review from a team as a code owner July 27, 2025 06:02
@jandubois
Add --errexit flag to enable errexit in run commands
507da84 
Set BATS_RUN_ERREXIT environment variable when flag is provided.
Write $? to a temp file when errexit is enabled.

Fixes bats-core#719
Fixes bats-core#748

Signed-off-by: Jan Dubois <[email protected]>
@jandubois
Copy link
Contributor Author

jandubois commented Jul 27, 2025 •
edited
Loading

I believe I have addressed all failures found by CI related to the PR.

  • The Windows tests are cancelled because the windows-2019 runner has been retired.
  • The Dockerfile test failure seems unrelated to the changes in this PR and fails on other PRs too.

@brokenpip3
Copy link
Contributor

brokenpip3 commented Jul 27, 2025

I believe I have addressed all failures found by CI related to the PR.

* The Windows tests are cancelled because the windows-2019 runner has been retired.

* The Dockerfile test failure seems unrelated to the changes in this PR and fails on other PRs too.

yes indeed, will take a look

@jandubois jandubois mentioned this pull request Aug 6, 2025
Closed
@jandubois
Copy link
Contributor Author

jandubois commented Aug 22, 2025

I added another commit to the PR to make sure the tmp directory exists. Otherwise it can fail when run() is called outside a @test block (which maybe you are not supposed to do, but it works):

# .../bats-core/test_functions.bash: line 396: BATS_FILE_TMPDIR: unbound variable

This was already broken if you called run() with --separate-stderr ourside a @test block, and is fixed here as well.

jandubois added a commit to jandubois/rancher-desktop that referenced this pull request Aug 22, 2025
@jandubois
Bump bats-core submodule to include the BATS_RUN_ERREXIT PR
81af8ff 
Ref bats-core/bats-core#1118

Signed-off-by: Jan Dubois <[email protected]>
@jandubois jandubois mentioned this pull request Sep 5, 2025
Merged
@AkihiroSuda AkihiroSuda mentioned this pull request Sep 24, 2025
Merged
@AkihiroSuda
Copy link

AkihiroSuda commented Nov 19, 2025

Maybe rebase to pass the CI ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow for set -e in run errexit is ignored in functions executed via run

3 participants

@jandubois @brokenpip3 @AkihiroSuda