Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cpswan
Copy link
Contributor

@cpswan cpswan commented Feb 11, 2019

Signed-off-by: Chris Swan <@cpswan>

@cpswan cpswan requested a review from a team as a code owner February 11, 2019 15:43
@ghost ghost assigned sublimino Feb 11, 2019
@ghost ghost added the review label Feb 11, 2019
@sublimino
Copy link
Member

Thanks @cpswan - I don't have it to hand, but I believe in Git Bash $PATH is already configured for ~/bin and have added wording to that effect.

Can you verify what I've added is correct please?

(n.b. I had to re-edit and force push my change from my local machine to get my GPG signature)

@cpswan
Copy link
Contributor Author

cpswan commented Feb 11, 2019

Thanks @sublimino

Git Bash doesn't use ~ in its PATH, but the full name of $HOME/bin (e.g. /c/Users/Whoever/bin) is there, which is equivalent to ~/bin. So your expanded instructions are correct.

@sublimino
Copy link
Member

Me writing one thing in a PR and another in the commit is the height of confusion on my behalf, thanks for clarification!

LGTM, thank you @cpswan :D

@sublimino sublimino merged commit 8b0fe23 into bats-core:master Feb 11, 2019
@ghost ghost removed the review label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants