Fix for tests reading from stdin #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative would be e.g. redirecting /dev/null do stdin for the test commands, see e.g. https://stackoverflow.com/questions/13800225/shell-script-while-read-line-loop-stops-after-the-first-line But I think this solution is better as it only relies on "simply" bashisms like iterating over a previously filled array. It also avoids an issue if the path to the test file contains a TAB |
c5d200d to
003f3d4
Compare
|
Thanks @Flamefire, this LGTM. Agreed on "simply Bashisms". Anybody else from @bats-core/bats-core or @cyphar want to have a look? |
|
LGTM from me. Thanks @Flamefire! |
sublimino
requested changes
Jun 28, 2019
Can happen e.g. when test code reads stdin which consumes remaining tests and was silently ignored (OK returned) This now makes the test run fail if not all tests were executed
Use an array to iterate over to avoid using stdin for test orchestration Fixes bats-core#197
Move to bats folder as it is a single test Extracting into an own command file required to use `bash -c`
sublimino
approved these changes
Jul 4, 2019
|
Awesome! Fast and clean. Cheers @Flamefire : ] I'll keep on with your changes in other PRs, sorry it's a bit slow -- we'll get there 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #197 the PR #172 introduced a change which broke the test runner when the test consumed stdin (containing remaining tests) by
Iterating over the
all_testsarray previously created and split at the last TAB found. By construction of the test lines this should work in all cases (test function names cannot contain a TAB)count number of executed tests and fail if it doesn't match number of tests that were scheduled
show number of not-run tests in the pretty-printer summary by counting passed tests
I have reviewed the Contributor Guidelines.
I have reviewed the Code of Conduct and agree to abide by it