Fix wrong line numbers of errors in bash < 4.4 #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last entry in the stack trace is unreliable, so don't use the last stack trace at all similar to the LINENO used before.
|
This seems fairly reasonable, we'll get it merged next 👍 |
|
@Flamefire I've made some minor changes during review and PR'd them to your branch instead of reviews here. If you're happy with them please merge on your branch, and I'll merge here. Otherwise I'm happy to open them for discussion here instead 🙏 |
…mino Add extra test and rename some variables
|
LGTM merged. Thanks! |
|
Many thanks once more @Flamefire! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last entry in the stack trace is unreliable, so don't use the last
stack trace at all similar to the LINENO used before.
Fixes #228