feat: backport 2.x features for interoperability#657
Merged
alexeagle merged 1 commit intobazel-contrib:1.xfrom Nov 16, 2023
Merged
feat: backport 2.x features for interoperability#657alexeagle merged 1 commit intobazel-contrib:1.xfrom
alexeagle merged 1 commit intobazel-contrib:1.xfrom
Conversation
5517d50 to
3e5d2ca
Compare
alexeagle
approved these changes
Nov 16, 2023
3e5d2ca to
3f6f9e7
Compare
95fd2f7 to
a72c63e
Compare
a72c63e to
b0e16ea
Compare
kormide
commented
Nov 16, 2023
Comment on lines
-16
to
+23
| ext = use_extension("@aspect_bazel_lib//lib:extensions.bzl", "ext") | ||
| use_repo(ext, "copy_directory_toolchains", "copy_to_directory_toolchains", "coreutils_toolchains", "expand_template_toolchains", "jq_toolchains", "yq_toolchains") | ||
| bazel_lib_toolchains = use_extension("@aspect_bazel_lib//lib:extensions.bzl", "toolchains") | ||
| bazel_lib_toolchains.copy_directory() | ||
| bazel_lib_toolchains.copy_to_directory() | ||
| bazel_lib_toolchains.jq() | ||
| bazel_lib_toolchains.yq() | ||
| bazel_lib_toolchains.coreutils() | ||
| bazel_lib_toolchains.expand_template() | ||
| use_repo(bazel_lib_toolchains, "copy_directory_toolchains", "copy_to_directory_toolchains", "coreutils_toolchains", "expand_template_toolchains", "jq_toolchains", "yq_toolchains") |
Collaborator
Author
There was a problem hiding this comment.
This is not a breaking change. The new extension registers the same toochains. We just no longer use the old extension to do it.
Collaborator
There was a problem hiding this comment.
okay thanks for explaining
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For downstream rulesets to use bazel-lib 1.x and 2.x, some features need to be added back to 1.x for a new release. These include:
Type of change
Test plan
Manual testing against against rules_js and rules_ts overriden to point to this PR.