Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

oreiche
Copy link
Contributor

@oreiche oreiche commented May 26, 2023

It officially supports the protocol in its client and server implementations.

@oreiche oreiche requested a review from bergsieker as a code owner May 26, 2023 10:43
@google-cla
Copy link

google-cla bot commented May 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@oreiche oreiche force-pushed the oreiche/justbuild branch from bf09591 to 6aa4ddb Compare May 26, 2023 10:46
@mostynb
Copy link
Contributor

mostynb commented May 28, 2023

I wonder if it's worth mentioning the need for the –compatible flag here? Just users might find this confusing otherwise.

@oreiche oreiche force-pushed the oreiche/justbuild branch from 6aa4ddb to 371f8bd Compare May 30, 2023 10:00
@oreiche
Copy link
Contributor Author

oreiche commented May 30, 2023

I wonder if it's worth mentioning the need for the –compatible flag here? Just users might find this confusing otherwise.

Agreed, I added a note in parentheses to both list entries.

@bergsieker bergsieker merged commit a985e26 into bazelbuild:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants