inline hinting for ExecuteRequest #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match the capabilities of GetActionRequest to support hints for composing ActionResults for Execute
bergsieker
approved these changes
Feb 13, 2024
EdSchouten
reviewed
Feb 14, 2024
Conceptually that's fine, but given that the messages already exist in one place, I think it's better to just duplicate them here than to force another migration from moving fields around. The practical implication of switching to a nested message would be that clients end up needing to set both fields in GetActionRequest indefinitely. |
|
@bergsieker good for a merge? no privs here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the capabilities of GetActionRequest to support hints for composing ActionResults for Execute