Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support size ranges #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kamieniarz wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Support size ranges #155

kamieniarz wants to merge 14 commits into from

Conversation

@kamieniarz
Copy link
Contributor

@kamieniarz kamieniarz commented Oct 26, 2023 •
edited
Loading

I decided to fix an ugly issue with sizes I described here: https://discord.com/channels/358180805031493634/786241014037741609/1150152266012184659

Pros:

  • [new] users can select min. and max. sizes on add page and edit modal
  • [fix] when someone tracks everything there's no more XXS label (no label to be more specific) - edit modal has ALL selected

Cons:

  • no validation for cases where size>max_size - just a warning instead
  • code is proly bad quality - I have no idea what I'm doing but it works ;)

@kamieniarz kamieniarz changed the title Fix sizes issue [ugly way] Fix sizes issue - support size ranges Oct 26, 2023
@kamieniarz kamieniarz changed the title Fix sizes issue - support size ranges Fix sizes issue + support size ranges Oct 26, 2023
@kamieniarz kamieniarz changed the title Fix sizes issue + support size ranges Support size ranges Oct 26, 2023
@bbdoc
Copy link
Owner

bbdoc commented Oct 28, 2023

I'll keep this open while I'm thinking about the best way to implement those changes.

I have already updated the display part, so could you please revert your changes to it and pull the latest changes.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kamieniarz @bbdoc