added options to normalize text, escape text, and optimize for disk v… #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iewing This is for issue bbolli#159 . I was having a similar issue with special characters as well as with tag upper/lower case. I have added three new options and the code to implement the options. --normalize-tags - sets the text to lower case and creates a unique set to remove duplicates --escape-tags - uses urllib.quote_plus to escape special characters in the tags --fix-for-disk - adds an extra urllib.quote_plus when the urls are being built to account for browsing from disk weirdness in windows
|
So, why would you not want to escape special characters in tags? I think we should unconditionally avoid things that crash tumblr-utils, like trying to create directories with invalid names. |
|
There is only so much you can code for. :-) I would agree about creating directories without special characters. The only place I see that happening is in the tag creation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iewing
This is for issue #159 . I was having a similar issue with special characters as well as with tag upper/lower case.
I have added three new options and the code to implement the options.
--normalize-tags - sets the text to lower case and creates a unique set to remove duplicates
--escape-tags - uses urllib.quote_plus to escape special characters in the tags
--fix-for-disk - adds an extra urllib.quote_plus when the urls are being built to account for browsing from disk weirdness in windows