-
Notifications
You must be signed in to change notification settings - Fork 45
PIMS-426 Routes LTSA #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-426 Routes LTSA #1984
Conversation
|
Code Climate has analyzed commit cd89a5b and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0%. View more on Code Climate. |
TaylorFries
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got 501: Not yet implemented which is what we expect at this point. Approved.
1daaa78 to
cd89a5b
Compare
|
Noting that the swagger comments for the LTSA controller don't seem to be picked up by the swagger-autogen. Waiting to see what happens with future routes. Tried a few things, but for some reason it's only that route while the health check works fine. |
🎯 Summary
PIMS-426
Changes
Creating route for LTSA GET request.
Currently uses a stub response. Recommend using this until the controller logic is completed at a later date.
Testing
Using a token from PIMS, call the
api/v2/ltsa/land/titleendpoint. Should get a 501 response.Future Work
🔰 Checklist