Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Dec 18, 2023

🎯 Summary

PIMS-426

Changes

Creating route for LTSA GET request.
Currently uses a stub response. Recommend using this until the controller logic is completed at a later date.

Testing

Using a token from PIMS, call the api/v2/ltsa/land/title endpoint. Should get a 501 response.

Future Work

  • Need to determine how Keycloak will be handled in future integration tests. Currently in conversations with the SSO team on this. Update: They recommend mocking any of the authentication. I added an example of how to add user info into a Request in the unit test. Not sure yet if we can mock the entire keycloak package. Might need to just do a bypass of it entirely.
  • Need to be specific in which roles can access this route. Right now it is all of them.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Dec 18, 2023
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Dec 18, 2023

Code Climate has analyzed commit cd89a5b and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.

@dbarkowsky dbarkowsky marked this pull request as ready for review December 19, 2023 01:06
Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got 501: Not yet implemented which is what we expect at this point. Approved.

@dbarkowsky dbarkowsky force-pushed the PIMS-426-Routes--LTSA branch from 1daaa78 to cd89a5b Compare December 20, 2023 00:07
@dbarkowsky
Copy link
Collaborator Author

Noting that the swagger comments for the LTSA controller don't seem to be picked up by the swagger-autogen. Waiting to see what happens with future routes. Tried a few things, but for some reason it's only that route while the health check works fine.

@dbarkowsky dbarkowsky merged commit e775280 into main Dec 20, 2023
@dbarkowsky dbarkowsky deleted the PIMS-426-Routes--LTSA branch December 20, 2023 00:10
TaylorFries pushed a commit that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants