Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-540,541,613 Update eslint #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TaylorFries merged 3 commits into from
Dec 21, 2023
Merged

PIMS-540,541,613 Update eslint #1988

TaylorFries merged 3 commits into from
Dec 21, 2023

Conversation

@TaylorFries
Copy link
Collaborator

@TaylorFries TaylorFries commented Dec 19, 2023

🎯 Summary

PIMS-540
PIMS-541
PIMS-613

Updating the following eslint packages:

  • @typescript-eslint/eslint-plugin from version 6.13.1 to 6.14.0
  • @typescript-eslint/parser from version 6.13.1 to 6.14.0
  • eslint from version 8.55.0 to 8.56.0

npm run lint and npm run lint:fix run as expected. No errors detected.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@github-actions
Copy link

github-actions bot commented Dec 19, 2023

🚀 Deployment Information

The APP Image has been built with the tag: 1988. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Dec 19, 2023 •
edited
Loading

Code Climate has analyzed commit c161aae and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.8%.

View more on Code Climate.

@TaylorFries TaylorFries self-assigned this Dec 19, 2023
dbarkowsky
dbarkowsky approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting commands running as expected. All testing passes.

@TaylorFries TaylorFries merged commit b787596 into main Dec 21, 2023
@TaylorFries TaylorFries deleted the PIMS-update-eslint branch December 21, 2023 18:17
TaylorFries added a commit that referenced this pull request Jan 3, 2024
@TaylorFries @dbarkowsky
PIMS-540,541,613 Update eslint (#1988)
cae4efa 
Co-authored-by: Dylan Barkowsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbarkowsky dbarkowsky dbarkowsky approved these changes

@LawrenceLau2020 LawrenceLau2020 Awaiting requested review from LawrenceLau2020 LawrenceLau2020 is a code owner

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@GrahamS-Quartech GrahamS-Quartech Awaiting requested review from GrahamS-Quartech

Assignees

@TaylorFries TaylorFries

Labels

Dependencies React

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TaylorFries @dbarkowsky