Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-422 Projects stubs#2012

Merged
dbarkowsky merged 7 commits intomainfrom
PIMS-422-Projects
Jan 5, 2024
Merged

PIMS-422 Projects stubs#2012
dbarkowsky merged 7 commits intomainfrom
PIMS-422-Projects

Conversation

@GrahamS-Quartech
Copy link
Contributor

🎯 Summary

PIMS-422:

  • Added stubs for routes, controllers, and tests.
  • Added some fairly robust factories in the tests but these objects are kind of enormous so I simplified slightly in some spots.
  • I skipped routes that had /report as their root cause I think that belongs in the reports ticket. There were also some routes already implemented by the notifications ticket.
  • Left some notes inline for the routes again, but these ones mostly make sense. Will add to the issue discussion as well.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jan 3, 2024

Code Climate has analyzed commit 9146333 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 78.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.3%.

View more on Code Climate.

@dbarkowsky dbarkowsky merged commit dd3b123 into main Jan 5, 2024
@dbarkowsky dbarkowsky deleted the PIMS-422-Projects branch January 5, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments