Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@GrahamS-Quartech
Copy link
Contributor

🎯 Summary

PIMS-631

  • Installed MUI's x-data-grid and material design icons. If we want different icons or no icons let me know but this seemed like a safe choice.
  • Added some basic styling and a custom menu component that can be opened from a button in the table rows.
  • Added some example usage with some placeholder data, status chips, and actions menu under the /dev route.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Works as expected.
Glad we're going with MUI Data Grid.

@dbarkowsky
Copy link
Collaborator

Tests were failing after recent merge. I think the issue is with the moduleNameMapper in jest.config.ts. It only appears to recognize the first match, so it matches the import for pictures matching @/assets/images... but then fails to activate the following map that would replace it with a mock. Not sure how to address this yet, so I've just gutted that test for now.

@dbarkowsky dbarkowsky merged commit bffc960 into main Jan 18, 2024
@dbarkowsky dbarkowsky deleted the PIMS-631-TableComponent branch January 18, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants