Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-684 Change how address info is stored #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbarkowsky merged 3 commits into from
Jan 19, 2024
Merged

PIMS-684 Change how address info is stored #2042

dbarkowsky merged 3 commits into from
Jan 19, 2024

Conversation

@dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Jan 18, 2024

🎯 Summary

PIMS-684

Changes

  • Address lines 1, 2, and postal are moved within the Property base entity
  • Properties now have a reference to an AdministrativeArea
  • AdminstrativeAreas now have references to Provinces
  • No more Addresses entity
  • Added a SiteId to the Property entity to store lookup value from geocoder

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Jan 18, 2024
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jan 18, 2024 •
edited
Loading

Code Climate has analyzed commit fb852ad and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.8%.

View more on Code Climate.

@dbarkowsky dbarkowsky merged commit 599a6bd into main Jan 19, 2024
@dbarkowsky dbarkowsky deleted the PIMS-684-Property-Address-Changes branch January 19, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LawrenceLau2020 LawrenceLau2020 LawrenceLau2020 approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@GrahamS-Quartech GrahamS-Quartech Awaiting requested review from GrahamS-Quartech

Assignees

@dbarkowsky dbarkowsky

Labels

Express

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbarkowsky @LawrenceLau2020