Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-1349: Create Building Service #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sharala-Perumal merged 34 commits into from
Mar 21, 2024
Merged

PIMS-1349: Create Building Service #2210

Sharala-Perumal merged 34 commits into from
Mar 21, 2024

Conversation

@Sharala-Perumal
Copy link
Collaborator

@Sharala-Perumal Sharala-Perumal commented Feb 23, 2024

PIMS-1339: Create Building Service

  • Created Building Service
  • Created mockup data for unit test
  • Created unit test for buildingService

🎯 Summary

PIMS-1339

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@Sharala-Perumal Sharala-Perumal self-assigned this Feb 23, 2024
@github-actions
Copy link

github-actions bot commented Feb 23, 2024

🚀 Deployment Information

The API Image has been built with the tag: 2210. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Feb 23, 2024 •
edited
Loading

Code Climate has analyzed commit 960fefd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 96.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.2%.

View more on Code Climate.

dbarkowsky
dbarkowsky reviewed Mar 19, 2024
View reviewed changes
GrahamS-Quartech
GrahamS-Quartech reviewed Mar 20, 2024
View reviewed changes
@Sharala-Perumal Sharala-Perumal merged commit 59e3bf0 into main Mar 21, 2024
@Sharala-Perumal Sharala-Perumal deleted the PIMS-1349 branch March 21, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbarkowsky dbarkowsky dbarkowsky approved these changes

@LawrenceLau2020 LawrenceLau2020 Awaiting requested review from LawrenceLau2020 LawrenceLau2020 is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

+1 more reviewer

@GrahamS-Quartech GrahamS-Quartech GrahamS-Quartech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Sharala-Perumal Sharala-Perumal

Labels

Express

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sharala-Perumal @dbarkowsky @GrahamS-Quartech @TaylorFries