Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Mar 11, 2024

🎯 Summary

PIMS-1371

Changes

  • Removed AccessRequest entity
  • Changed UpdatedOn columns to be automatically updated
  • Remove ParcelBuilding entity
  • Move PID/PIN fields to Property entity so both parcels and buildings will have them
  • Create a view (BuildingRelations) that can be used to reference property/building associations
  • Add new migration files to accommodate changes

Testing

  1. Run migrations (can just start API)
  2. Check database to see the new changes.

Future Work

  • Update ETL so that the buildings are populated with PID/PIN if they have associated parcels in old PIMS

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Mar 11, 2024

Code Climate has analyzed commit de7bb6d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.8%.

View more on Code Climate.

LEFT OUTER JOIN parcel p
ON b.pid = p.pid OR b.pin = p.pin;
`);
await queryRunner.query(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is writing directly to this table correct? Seems like something that should be auto-generated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was what the TypeORM package generated. I didn't manually write this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense 👍

@dbarkowsky
Copy link
Collaborator Author

Made a few changes from PIMS-1375.

There weren't any notable updates to the Parcel service, but I tried to clean out some old interfaces and add references to Buildings and Parcels to more easily access their Evaluations and Fiscals.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migrations work as expected and database updates look good.

@dbarkowsky dbarkowsky merged commit 09966bd into main Mar 13, 2024
@dbarkowsky dbarkowsky deleted the PIMS-1373-ParcelBuildings-Restructure-Entities branch March 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants