Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-1370: CHES Service#2242

Merged
GrahamS-Quartech merged 15 commits intomainfrom
PIMS-1370-CHESService
Mar 13, 2024
Merged

PIMS-1370: CHES Service#2242
GrahamS-Quartech merged 15 commits intomainfrom
PIMS-1370-CHESService

Conversation

@GrahamS-Quartech
Copy link
Contributor

🎯 Summary

PIMS-1370

  • This implements the CHES service for sending email notifications. Does not include templates.
  • I have added an additional endpoint for sending emails that was not in the original spec, previously the send service was only called internally as part of the notification system, which is currently unimplemented. I figure I'll leave this in until it's deemed unnecessary, since I don't know whether the notification system will be kept/discarded/reworked etc.
  • You'll notice that a lot of environment variables are expected. Previously this configuration was handled by the .NET appsettings json configuration, so this is my equivalent, though I'm open to suggestions on another way to do it.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@github-actions
Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2242. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Mar 13, 2024

Code Climate has analyzed commit cd5321c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 97.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.8%.

View more on Code Climate.

@GrahamS-Quartech GrahamS-Quartech merged commit 4227623 into main Mar 13, 2024
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1370-CHESService branch March 13, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments