Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-1403 Agency Table #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbarkowsky merged 7 commits into from
Mar 25, 2024
Merged

PIMS-1403 Agency Table #2274

dbarkowsky merged 7 commits into from
Mar 25, 2024

Conversation

@dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Mar 25, 2024

🎯 Summary

PIMS-1403

Changes

  • Adds an API hook to get agencies with the parent relation attached
  • Adds a page and table for showing agencies

Next Ticket

  • Agency Detail Page

Testing

  • Go to /admin/agencies to view the table.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Mar 25, 2024
@github-actions
Copy link

github-actions bot commented Mar 25, 2024

🚀 Deployment Information

The Express API Image has been built with the tag: 2274. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

@github-actions
Copy link

github-actions bot commented Mar 25, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2274. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Mar 25, 2024 •
edited
Loading

Code Climate has analyzed commit 8f4f94c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.0%.

View more on Code Climate.

@dbarkowsky dbarkowsky marked this pull request as ready for review March 25, 2024 20:57
LawrenceLau2020
LawrenceLau2020 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, able to use the sorting and filter features as well!

@dbarkowsky dbarkowsky merged commit a4a037e into main Mar 25, 2024
@dbarkowsky dbarkowsky deleted the PIMS-1403-Agency-Table branch March 25, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LawrenceLau2020 LawrenceLau2020 LawrenceLau2020 approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@GrahamS-Quartech GrahamS-Quartech Awaiting requested review from GrahamS-Quartech

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

@dbarkowsky dbarkowsky

Labels

Express

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbarkowsky @LawrenceLau2020