PIMS-1529: Projects Controller - addProject #2336
Conversation
|
🚀 Deployment Information The Express API Image has been built with the tag: |
|
Code Climate has analyzed commit 0a5f222 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 93.9%. View more on Code Climate. |
| import { DeepPartial } from 'typeorm'; | ||
| import { Project } from '@/typeorm/Entities/Project'; | ||
|
|
||
| interface ProjectPropertyIds { |
There was a problem hiding this comment.
There's already the same type as an exported member of projectsServices, probably best to consolidate this to one place.
| const { | ||
| project, | ||
| propertyIds, | ||
| }: { project: DeepPartial<Project>; propertyIds: ProjectPropertyIds } = req.body; |
There was a problem hiding this comment.
Do we care about the length of the propertyIds arrays at all? Is a project with no properties allowed to be created?
There was a problem hiding this comment.
That's a good question, as this was possible in the old PIMS and a user could start creating a project save it and enter the properties at a later time.
There was a problem hiding this comment.
That being the case, I think I'm fine with keeping this as a valid option for now
🎯 Summary
PIMS-1529:
Adding the service function to the addDisposalProject endpoint.
Still need to add some user permissions check.
🔰 Checklist