Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-1368: Convert Notifications Templates to Nunjucks #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GrahamS-Quartech merged 10 commits into from
May 1, 2024
Merged

PIMS-1368: Convert Notifications Templates to Nunjucks #2362

GrahamS-Quartech merged 10 commits into from
May 1, 2024

Conversation

@GrahamS-Quartech
Copy link
Contributor

@GrahamS-Quartech GrahamS-Quartech commented May 1, 2024

🎯 Summary

PIMS-1368

  • Converts every existing notification template from the C# .NET style format to Nunjucks format.
  • These overwrite the database rows with a migration, but there's a down direction to revert if needed.
  • If you want to test, could just do a nunjuck.render() in the health controller temporarily.
  • Wasn't sure if we should leave the template files that I added or delete them. Thoughts?

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@github-actions
Copy link

github-actions bot commented May 1, 2024

🚀 Deployment Information

The Express API Image has been built with the tag: 2362. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented May 1, 2024 •
edited
Loading

Code Climate has analyzed commit ae3bace and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 75.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.0%.

View more on Code Climate.

dbarkowsky
dbarkowsky approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Made some changes to add ending new lines and to address this long-outstanding ticket:
https://citz-imb.atlassian.net/browse/PIMS-1381?atlOrigin=eyJpIjoiNWJkM2ZiY2ExMDA1NGI2Yjg0MGEwZmZiMzlhNzVlMzkiLCJwIjoiaiJ9

@GrahamS-Quartech GrahamS-Quartech merged commit b0f3392 into main May 1, 2024
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1368-Convert-Notifications branch May 1, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbarkowsky dbarkowsky dbarkowsky approved these changes

@LawrenceLau2020 LawrenceLau2020 LawrenceLau2020 approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

No one assigned

Labels

Dependencies Express

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GrahamS-Quartech @dbarkowsky @LawrenceLau2020