PIMS: 1656 & 1658 - Create getTitleSummary and createOrder endpoints for LTSA #2363
Conversation
dbarkowsky
left a comment
There was a problem hiding this comment.
Standardized some naming that was causing a build issue.
Added some strong typing to these functions.
Tested, and it all seems to be working as expected.
Now we just need tests.
|
|
||
| // TODO: Replace stub response with controller logic | ||
| return stubResponse(res); | ||
| if (!getLandTitleInfo) { |
There was a problem hiding this comment.
I think we might never trigger this. The service throws errors if it fails. It doesn't just return a response with no data.
There was a problem hiding this comment.
Implemented suggested change
|
Code Climate has analyzed commit 9ca6f51 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.2% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.5%. View more on Code Climate. |
| @@ -0,0 +1,4 @@ | |||
| export interface ILtsaTokens { | |||
There was a problem hiding this comment.
I feel like an interface this small doesn't really necessitate its own file. You could probably consolidate all these interfaces to one place.
There was a problem hiding this comment.
I feel like an interface this small doesn't really necessitate its own file. You could probably consolidate all these interfaces to one place.
LTSA process is broken into 3 bits - get Tokens, get Title summary, get order Info. I created one interface per bit for readability purposes. If the standard is to consolidate all into one, I'm happy to do that :)
dbarkowsky
left a comment
There was a problem hiding this comment.
Works well in testing. Implementation matches that from old PIMS.
PIMS-1656/1658: Create getTitleSummary and createOrder endpoints for LTSA
🎯 Summary
PIMS-1656
PIMS-1658
🔰 Checklist