Conversation
|
🚀 Deployment Information The React APP Image has been built with the tag: |
dbarkowsky
approved these changes
May 14, 2024
Collaborator
dbarkowsky
left a comment
There was a problem hiding this comment.
Working great. I made one change to centralize the styles in the context provider. Just want to keep it consistent when it gets used around the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
PIMS-1674
Can't take too much credit for this, as it's largely borrowed from previous work @dbarkowsky did in the link from the Jira ticket. I've modified it lightly to a bit more generic and compatible with the usage in our project.
I've implemented some basic usage of this context in the user page only. I think that there should be a follow up task to this to improve on the general submission flow, giving us a way to consistently call PUT/POST requests that will expose a loading prop and set the snackbar context depending on the status returned by the response. We can get this snackbar popping up everywhere in that task.
🔰 Checklist