Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-1708: Notes Backend #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GrahamS-Quartech merged 7 commits into from
May 29, 2024
Merged

PIMS-1708: Notes Backend #2411

GrahamS-Quartech merged 7 commits into from
May 29, 2024

Conversation

@GrahamS-Quartech
Copy link
Contributor

@GrahamS-Quartech GrahamS-Quartech commented May 28, 2024

🎯 Summary

PIMS-1708

  • Notes are now included when getting a project by ID
  • There's an additional handler for updating project notes while updating a project. Notes are only upserted and not deleted (I figure notes will just update to an empty string rather than have the row itself deleted)
  • Added a migration that makes the index on the column pair (project_id, note_type) unique to make the conflict condition in the upsert possible.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@github-actions
Copy link

github-actions bot commented May 28, 2024

🚀 Deployment Information

The Express API Image has been built with the tag: 2411. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented May 28, 2024 •
edited
Loading

Code Climate has analyzed commit 5fe21b8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.5%.

View more on Code Climate.

dbarkowsky
dbarkowsky approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with these changes. Would be nice to fix that issue on the Details page where the Description field reads notes if possible.

@GrahamS-Quartech GrahamS-Quartech merged commit f3a1175 into main May 29, 2024
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1708-NotesBackend branch May 29, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbarkowsky dbarkowsky dbarkowsky approved these changes

@LawrenceLau2020 LawrenceLau2020 Awaiting requested review from LawrenceLau2020 LawrenceLau2020 is a code owner

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

No one assigned

Labels

Express

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GrahamS-Quartech @dbarkowsky