Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-1986: Remove LegalLandDescription from Parcels#2635

Merged
LawrenceLau2020 merged 2 commits intomainfrom
PIMS-1986
Aug 21, 2024
Merged

PIMS-1986: Remove LegalLandDescription from Parcels#2635
LawrenceLau2020 merged 2 commits intomainfrom
PIMS-1986

Conversation

@LawrenceLau2020
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 commented Aug 19, 2024 •
edited
Loading

🎯 Summary

PIMS-1986:

  • New TypeORM migration to remove the LandLegalDescription column from the parcel entity.
  • Removed this field from the PropertyForm, nunjucks templates and other files
  • Created another migration to remove this field from the NotificationTemplates database table.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@LawrenceLau2020 LawrenceLau2020 self-assigned this Aug 19, 2024
@github-actions
Copy link

github-actions bot commented Aug 19, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2635. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Aug 20, 2024

Code Climate has analyzed commit 308ed55 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.5%.

View more on Code Climate.

@dbarkowsky
Copy link
Collaborator

dbarkowsky commented Aug 20, 2024

Using this query, I still get 11 notification templates with the word legal.
select body from notification_template where body ilike '%legal%';

My notification when creating a new project looks like this, so I think there are still some out there.
image

dbarkowsky
dbarkowsky approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again. No issues this time. Not sure what was causing them the first time, but assume it was a me issue.

@LawrenceLau2020 LawrenceLau2020 merged commit 032ac71 into main Aug 21, 2024
@LawrenceLau2020 LawrenceLau2020 deleted the PIMS-1986 branch August 21, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbarkowsky dbarkowsky dbarkowsky approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@GrahamS-Quartech GrahamS-Quartech Awaiting requested review from GrahamS-Quartech

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

@LawrenceLau2020 LawrenceLau2020

Labels

Express

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LawrenceLau2020 @dbarkowsky

Comments